Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][Vectorized] Fix DCHECK failed in VExchangeNode close twice #10184

Merged
merged 1 commit into from
Jun 16, 2022
Merged

[Bug][Vectorized] Fix DCHECK failed in VExchangeNode close twice #10184

merged 1 commit into from
Jun 16, 2022

Conversation

HappenLee
Copy link
Contributor

Proposed changes

Issue Number: close #10144

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

yiguolei
yiguolei approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 16, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@HappenLee HappenLee merged commit 8d98c17 into apache:master Jun 16, 2022
@morningman morningman added the dev/1.0.1-deprecated should be merged into dev-1.0.1 branch label Jun 17, 2022
@morningman morningman added this to the v1.1 milestone Jun 17, 2022
@morningman morningman added dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 and removed dev/1.0.1-deprecated should be merged into dev-1.0.1 branch labels Jun 17, 2022
morningman pushed a commit that referenced this pull request Jun 17, 2022
@HappenLee @morningman
[Bug][Vectorized] Fix DCHECK failed in VExchangeNode close twice (#10184
f9f6788 
)

Co-authored-by: lihaopeng <lihaopeng@baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. area/vectorization dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 reviewed
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

[Bug] Core dump in VExprContext::close DCHECK(!_closed)
3 participants
@HappenLee @yiguolei @morningman